Experts Round Table Network

The following is an SQL statement i am struggling with at the moment

Language: sql (GeSHi-highlighted)
$sql1 = "UPDATE custpayments SET depcardbal = depcardbal -". $totcardsubtotal.", projacctbal = projacctbal - ".$totprojsubtotal.", bankacctbal = bankacctbal - ".$bankacctwithdraw.", transfacctbal = transfacctbal - ".$transfacctwithdraw.", transactionstatus = '2' WHERE paytransacid = '".$paytransacid."'";

I get the following error message;


Thanks for any help you can provide.

Looks like your variables are empty.
You should make sure you initialize them (set them all to 0) when you declare them.

Or maybe try adding a leading zero to your amounts, but that's a quick and dirty fix...

(i like my SQL statements on multiple lines)

> $paytransacid
You should always pay for your trance acid ;.

the above is correct.

Moreover, you don't need to play with quotes the way you do, and your SQL phrase is not closed.

IMHO, it should read :
moreover, your variables are empty. Given they're numeric, they should be initialized explicitly at the start of your program/script (a good habit I inherited from Pascal).
A workaround#1 is to use the 0 trick
A workaround#2 is to add before the query line above :
A workaround#3 is to explictly cover the case in your SQL statement, but this is a bit overkill :

best regards

Thanks a lot for your help but the variables are actually retrieved from $_POST earlier on so if they are empty them something real strange is happening. Will have to look into that.

what I wrote is correct, as I usuammy use the same script for offering the FORM and treat the POSTed data.

In your case, always assign a value="0" to your (numeric) form fields. This way, they'll never be empty... Unless the user cleans them up manually, but this should be covered in the javascript client-side form data validation PRIOR to the actual submit. OR use what I said : $somevar=(isset())? stuff with $_POST['somevar'] in stead of $somevar.

like :